fix: editing coordinates manually would not be saved #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary coordinates is a two-elements Array in Point.coordinates, but FormBuilder does not know how to edit an Array, so we edit the `ui._latlngs` instead. The proper fix would have been to teach FormBuilder how to edit an Array, but that path is way longer, and given we plan to refactor it totally, let's wait for that. fix #2144
davidbgk
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary coordinates is a two-elements Array in Point.coordinates, but FormBuilder does not know how to edit an Array, so we edit the
ui._latlngsinstead.The proper fix would have been to teach FormBuilder how to edit an Array, but that path is way longer, and given we plan to refactor it totally, let's wait for that.
fix #2144