Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not show browser counter when layer is empty or not loaded #2217

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: do not show browser counter when layer is empty or not loaded #2217

merged 1 commit into from
Oct 16, 2024

Conversation

yohanboniface
Copy link
Member

fix #2215

davidbgk
davidbgk approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An early return would work too given that's a pattern already in use at line 85.

@yohanboniface yohanboniface force-pushed the fix-browser-counter-empty branch 2 times, most recently from 327b4da to 0977667 Compare October 15, 2024 21:08
@yohanboniface yohanboniface merged commit dab8bce into master Oct 16, 2024
4 checks passed
@yohanboniface yohanboniface deleted the fix-browser-counter-empty branch October 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hidden layers show '0' elements on load
2 participants
@yohanboniface @davidbgk