Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save & Publish with descendants does not save or publish the actual root node #14925

Open
Migaroez opened this issue Oct 5, 2023 · 3 comments
Labels
affected/v10 affected/v11 affected/v12 area/backend state/needs-investigation This requires input from HQ or community to proceed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@Migaroez
Copy link
Contributor

Migaroez commented Oct 5, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

Any v10 and upwards

Bug summary

Save & Publish with descendants publishes any children that are unpublished but have saved changes as expected. What seems unexpected is that changes made on the document where you are sending the intent from does not actually gets saved and published resulting in lost changes.

Specifics

Came across this issue trying to solve #14543, fixed that and this related bug, resulting in functional breaking behavior.
The original reported issue has been fixed in #14922 with the breaking behavior removed but this related 'bug' still exists.

Steps to reproduce

  • Create a root document
  • Create a child under the root
  • Rename the root and hit Save & Publish with Descendants.
  • Refresh the page

Expected result / actual result

Actual: The page rename is discarded and no message was shown that this was going to be the case.
Expected: The root is saved and published alongside any children that were in a saved state.


This item has been added to our backlog AB#33601

@Migaroez Migaroez self-assigned this Oct 5, 2023
@Migaroez Migaroez added the state/needs-investigation This requires input from HQ or community to proceed label Oct 5, 2023
@Migaroez Migaroez removed their assignment Oct 9, 2023
@Migaroez Migaroez added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Oct 9, 2023
@NurhakKaya
Copy link
Contributor

Hi,

I have started working on this issue.

Cheers,

Nurhak

@NurhakKaya
Copy link
Contributor

I can confirm that this is happening with the following Umbraco version. I'm now investigating the issue.

Umbraco version 12.2.0-rc.preview.62

@NurhakKaya
Copy link
Contributor

I have just had a chat with @Migaroez and he has warned me that this is an issue that needs to be discussed first before making any code changes, hence I'm stopping working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v10 affected/v11 affected/v12 area/backend state/needs-investigation This requires input from HQ or community to proceed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

2 participants