Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification state to "final" published notification when publishing with descendants #14922

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 5, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #14543

Description

This PR rolls back the functional breakage introduced by #14763 and fixes the original issue (#14543) in a non-breaking way.

Testing this PR

Create a notification handler that logs all "saving", "saved", "publishing" and "published" notifications for content.

Perform "save and publish" on an unpublished structure of content (including all unpublished descendants). Verify that:

  1. The same amount of notifications are fired before and after applying this PR, and in the same order.
  2. The "published" notification contains state from both the "saving" and the "publishing" notification of the root content being published.

@Migaroez
Copy link
Contributor

Migaroez commented Oct 5, 2023

Looks good!

@Migaroez Migaroez merged commit 04b0571 into v10/dev Oct 5, 2023
17 checks passed
@Migaroez Migaroez deleted the v10/fix/publish-descendants-notification-no-breakage branch October 5, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants