Backwards compatible upgrade to ImageSharp 2

[skttl]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #11938

Description

This upgrades ImageSharp and ImageSharp.Web to 2.0.0 without making breaking changes in Umbracos public API.

ImageSharp.Web 2.0.0 is still unreleased, so WIP until that gets released.

To test, check if image generation works, eg. https://localhost:44331/umbraco/assets/img/login.jpg?width=200&format=webp

[umbrabot]

Hi there @skttl, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Nuklon]

Very useful for v9 to get webp support!

[maartenmensink]

@skttl need any help with this?

I was to quick to use the SixLabors.ImageSharp.Web nuget was also released.

[skttl]

Hi @maartenmensink

ImageSharp.Web 2.0.0 hasn't been released yet: https://www.nuget.org/packages/SixLabors.ImageSharp.Web/

[maartenmensink]

Hi @maartenmensink

ImageSharp.Web 2.0.0 hasn't been released yet: https://www.nuget.org/packages/SixLabors.ImageSharp.Web/

Yeah sorry about i miss read the package name 🙈. Let me know if i can help when it is released!!! I want this feature back in my life 😄

[jaddie]

What's happening with this? If this is the case that its backwards compatible without any breaking changes then it would be great to get this integrated tbh as I was reading about this and its being spoken about for V10 instead which seems a long while off.

[skttl]

What's happening with this? If this is the case that its backwards compatible without any breaking changes then it would be great to get this integrated tbh as I was reading about this and its being spoken about for V10 instead which seems a long while off.

Imagesharp. Web 2 is still not released, and v10 is only a couple of months away, scheduled for release in q1 of 2022

[ronaldbarendse]

@skttl Thanks for trying to get this to work in v9, but simply updating a dependency to a new major version is considered a breaking change and because ImageSharp.Web v2 contains breaking changes that Umbraco uses (and is compiled against), upgrading your site to use v2 will throw exceptions during boot.

We might actually want to add an upper dependency version limit to v9, because we now know the newer major version is incompatible 🤔

Anyway, Umbraco 10 will ship with updated ImageSharp/ImageSharp.Web v2 dependencies (see the progress and details on PR #12185), so I'll close this one.