MNTP: Re-initialize contextual dialog options upon content creation #17301
+75
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #15770 (in part)
Description
Notice that #15770 covers two different issues:
This PR fixes the issue described in the original issue description by reloading the contextual dialog options, if the MNTP is part of a newly created document.
Another PR will be submitted to tackle the other contextual issues, as they are indeed a whole other issue.
Testing this PR
Follow the steps in the issue description in #15770 - it should work now after content creation.
Please notice that the screencast in the first comment of #15770 is somewhat off; it does not follow the steps, so don't follow the screencast when testing 😆