Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Render collection icon for document/media tree items #2069

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Bugfix: Render collection icon for document/media tree items #2069

merged 5 commits into from
Jul 2, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jul 1, 2024 •
edited
Loading

Description

This PR adds a "collection"-icon for tree items configured as a collection.

Currently, the UI only supports one icon, so if a document is protected both a collection and protected the protected state will win. (As in v13).

Screenshot 2024-07-01 at 15 21 39

How to test:

  • Set up a document/media collection. Ensure that a "collection" icon is shown in the tree.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review July 1, 2024 13:25
leekelleher
leekelleher approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, looking good! 🚀

@leekelleher leekelleher merged commit dc27f58 into main Jul 2, 2024
6 checks passed
@leekelleher leekelleher deleted the v14/bugfix/document-media-tree-item-collection-icon branch July 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
release/14.2.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @leekelleher @iOvergaard