Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Collection Toolbar Filter Field #2467

Merged
merged 12 commits into from
Oct 17, 2024

Conversation

leekelleher
Copy link
Member

Description

Since reviewing the Dictionary Collection toolbar filter (PR #2415) last week, I looked at the other Collection toolbars to see if we could de-duplicate the filter input code, to make a reusable component.

This PR introduces a <umb-collection-filter-field> component.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

How to test?

Try out the Collection toolbar filter field on the following areas, to make sure that it still works as expected.

  • Dictionary
  • Documents
  • Extension Insights
  • Media
  • Members
  • Users
  • User Groups

This should only display if the component has any contents.
Deprecates `umb-document-collection-toolbar`
Deprecates `umb-media-collection-toolbar`
Enables support for future Create and Views functionality.
deprecated the "default" export
Deprecates `umb-user-group-collection-header`
Reusable filter field for a collection toolbar.
on existing collections, removed duplicated code.
Seems that this may cause issues with the eslint plugin
(for ensuring element names start with "umb-").
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not sure if any of the now-deprecated elements were ever part of any index.ts export and available from the outside, so they could potentially be removed or have their exports changed already, but no comments other than that.

@leekelleher leekelleher merged commit dac0c03 into main Oct 17, 2024
9 checks passed
@leekelleher leekelleher deleted the v15/chore/collection-toolbar-refactor branch October 17, 2024 11:38
@leekelleher
Copy link
Member Author

@iOvergaard Thanks for the merge. 🙏

My thinking was that a 3rd-party extension may have use something like <umb-document-collection-toolbar> in their own components, as opposed to the UmbDocumentCollectionToolbarElement class/type explicitly. Personally I doubt anyone would be using that particular component externally, but still we don't know for sure. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants