Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: Added extra examples + explanation #6456

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

Yinzy00
Copy link
Contributor

@Yinzy00 Yinzy00 commented Sep 24, 2024

Description

I added extra examples + explanation to the menu docs for V14 and v15

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

V14, V15

@sofietoft
Copy link
Contributor

Thanks for this @Yinzy00 🙌 🎉

I've forwarded this to our developers, and I'll make sure we get it reviewed as soon as possible.

@sofietoft sofietoft added category/umbraco-cms state/needs-investigation This requires input from HQ or community to proceed labels Sep 25, 2024
Copy link
Contributor

@Frost117 Frost117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofietoft

I ran @Yinzy00 code examples locally and they work on my machine. LGTM :)

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty to correct some grammar 💪

Also, I've added a couple of comments.
Please let me know if something doesn't make sense!

Regarding the code snippets, I think it would be great if you could wrap them using the GitBook formats, so we can highlight the file name a little easier.
See the docs for reference: https://docs.gitbook.com/content-editor/blocks/code-block#representation-in-markdown

@sofietoft sofietoft removed the state/needs-investigation This requires input from HQ or community to proceed label Oct 9, 2024
@sofietoft
Copy link
Contributor

Looks like everything checks out here 🎉

Thanks again for putting in the effort to help us improve the Umbraco documentation.
MUCH appreciated 👏

I'll get this one merged!

@sofietoft sofietoft merged commit 5b275a6 into umbraco:main Oct 10, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants