-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu: Added extra examples + explanation #6456
Conversation
Thanks for this @Yinzy00 🙌 🎉 I've forwarded this to our developers, and I'll make sure we get it reviewed as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran @Yinzy00 code examples locally and they work on my machine. LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken the liberty to correct some grammar 💪
Also, I've added a couple of comments.
Please let me know if something doesn't make sense!
Regarding the code snippets, I think it would be great if you could wrap them using the GitBook formats, so we can highlight the file name a little easier.
See the docs for reference: https://docs.gitbook.com/content-editor/blocks/code-block#representation-in-markdown
14/umbraco-cms/customizing/extending-overview/extension-types/menu.md
Outdated
Show resolved
Hide resolved
Looks like everything checks out here 🎉 Thanks again for putting in the effort to help us improve the Umbraco documentation. I'll get this one merged! |
Description
I added extra examples + explanation to the menu docs for V14 and v15
Type of suggestion
Product & version (if relevant)
V14, V15