Porting old Umbraco API Controller [Extending > Database] #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sofietoft I don't know how to check off the task in the issue🙈 |
|
Amazing @erikjanwestendorp ! Thanks 😄 I've checked the article in the list on the Issue. |
|
I've tested the code now, and it compiles (with a few warnings, but nothing related to the "missing" API Controller) 👏 🎉 And great idea adding the suggestions from the Porting article 💪 Makes a whole lot of sense! I'll get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR belongs to: #6466. Change
UmbracoApiControllerto a defaultControllerand also added route attributes as suggested in the Porting old Umbraco API Controllers article. Happy hacktoberfest! 🎃UmbracoApiController
Type of suggestion
Product & version (if relevant)
Umbraco CMS v14 & 15