Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting old Umbraco API Controller [Debugging > Logging] #6513

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

erikjanwestendorp
Copy link
Contributor

Description

This PR belongs to: #6466.

  • Change UmbracoApiController to a default Controller
  • Added route attributes
  • Delete obsolete warning
  • Write shorter sentences

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Styleguide

Product & version (if relevant)

Umbraco CMS v14 & 15.

@sofietoft
Copy link
Contributor

Thanks @erikjanwestendorp ! 💪
We'll get this reviewed as soon as possible.

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @erikjanwestendorp ! 💪

Just a single comment - take a look and let me know what you think!

14/umbraco-cms/fundamentals/code/debugging/logging.md Outdated Show resolved Hide resolved
15/umbraco-cms/fundamentals/code/debugging/logging.md Outdated Show resolved Hide resolved
@erikjanwestendorp
Copy link
Contributor Author

@sofietoft Thanks for your review, just updated the PR with your suggestions also for v10 &13. 😄

@sofietoft
Copy link
Contributor

Amazing @erikjanwestendorp ! 🤩

Thanks again!
I'll get this merged - once the checks clear. Might need to make some minor changes to trigger it 🙈

@sofietoft sofietoft merged commit f8acd39 into umbraco:main Oct 8, 2024
22 checks passed
@erikjanwestendorp erikjanwestendorp deleted the update-logging branch October 8, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants