Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting old Umbraco API Controller [Common Pitfalls: Static references to scoped references] #6526

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Porting old Umbraco API Controller [Common Pitfalls: Static references to scoped references] #6526

merged 5 commits into from
Oct 7, 2024

Conversation

erikjanwestendorp
Copy link
Contributor

Description

This PR belongs to: #6466.

  • Change UmbracoApiController to a default Controller
  • Delete obsolete warning
  • Write shorter sentences
  • Define LINQ

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Styleguide

Product & version (if relevant)

Umbraco CMS v14 & 15

@sofietoft
Copy link
Contributor

Thanks for the PR @erikjanwestendorp ! 😄
We'll get this reviewed as soon as possible.

@sofietoft
Copy link
Contributor

Everything checks out 🎉 😄

Thanks again for adding the PR @erikjanwestendorp !

I'll get it merged.

@sofietoft sofietoft merged commit c86d948 into umbraco:main Oct 7, 2024
6 checks passed
@erikjanwestendorp erikjanwestendorp deleted the update-common-pitfalls branch October 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/umbraco-cms hacktoberfest/contrib-2024 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikjanwestendorp @sofietoft