Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deploy): allow fetching C4GH and regular files #273

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix(deploy): allow fetching C4GH and regular files #273

merged 1 commit into from
Oct 20, 2024

Conversation

mmalenic
Copy link
Member

Changes

  • Allows fetching both C4GH and regular files in the resolvers settings. Previously this was always attempting to get C4GH files even if the directory contained regular files.

@mmalenic mmalenic self-assigned this Oct 20, 2024
@mmalenic mmalenic added the fix fix a bug label Oct 20, 2024
brainstorm
brainstorm approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Tests failing though?

@mmalenic mmalenic added this pull request to the merge queue Oct 20, 2024
Merged via the queue into main with commit 18f33a8 Oct 20, 2024
4 of 5 checks passed
@brainstorm brainstorm deleted the fix/deploy-c4gh-settings branch October 20, 2024 22:36
@mmalenic
Copy link
Member Author

Good catch! Tests failing though?

It should be intermittent. It happens because each test launches a server on a new port, and sometimes the port is in use.

I'll see if there's a way to make it more consistent.

brainstorm added a commit that referenced this pull request Oct 21, 2024
@brainstorm
Add changes from #273
aba97f8
brainstorm added a commit that referenced this pull request Oct 22, 2024
@brainstorm
Add changes from #273
d19af5d
brainstorm added a commit that referenced this pull request Oct 22, 2024
@brainstorm
Add changes from #273
5ff9b5e
brainstorm added a commit that referenced this pull request Oct 22, 2024
@brainstorm
Add changes from #273
0f36759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
fix fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm