Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omit prefix symbol automatically when copying shell code #1832

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

codersjj
Copy link
Contributor

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

Taking Ant Design's docs as an example:

$ npm install antd --save

When you click the "Copy" button, the result will be:

$ npm install antd --save

After applying the code from this commit, the result will be:

npm install antd --save

This is more in line with expectations.

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English remove leading spaces and specific characters when copying shell code in SourceCode
🇨🇳 Chinese SourceCode 中复制 shell 代码时,去除行首的空格和特定字符

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 8:54am

- The initialValue of `text` should be the value of `children`.
- Here, `text` should be managed within the component's state, otherwise the new value of `text` will not be rendered even if the effect re-runs.
- `children` should also be a dependency.
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript changed the title feat: remove leading spaces and specific characters when copying shell code in SourceCode feat: omit prefix symbol automatically when copying shell code Aug 16, 2023
@PeachScript PeachScript merged commit 7e01156 into umijs:master Aug 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants