fix: unexpected exports in demo pre-compiling result #1926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是?/ What is the nature of this change?
🔗 相关 Issue / Related Issue
Close #1920
💡 需求背景和解决方案 / Background or solution
修复 dumi v1 demo 预编译结果中包含非预期
exports
导致编译报错的问题。大致原因:
exports['default'] = function _default() {}
的语句)考虑到 dumi 1 已经不再迭代,精力有限上述猜想就不继续验证了
解决方案:
exports['default'] = function _default() {}
也做转换,目前只转了exports['default'] = _default
,该方案的好处是代码改动量很小,加上 Babel 8 已经进入 alpha 阶段,v7 未来再出现类似影响的概率较小,所以选择平衡解📝 更新日志 / Changelog