Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode error #2158

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: dark mode error #2158

merged 1 commit into from
Jul 2, 2024

Conversation

Jinbao1001
Copy link
Member

@Jinbao1001 Jinbao1001 commented Jul 2, 2024

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

lessOptions 之前被错误读取, 应该直接读 lessLoader.modifyVars
因为 theme 始终会被 lessLoader 覆盖, 所以在存在 lessLoader 配置的情况下一定要设置 dark-selector

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English dark mode error
🇨🇳 Chinese 暗黑模式 lessloader传参错误

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 1:47pm

@Jinbao1001 Jinbao1001 merged commit b109266 into master Jul 2, 2024
10 checks passed
@Jinbao1001 Jinbao1001 deleted the fix/theme branch July 2, 2024 13:56
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充 PR 描述,至少包含原因和解法,如果有引入来源也需要标记

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants