-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use define to inject SEARCH_WORKER_CODE instead of resourcequery dumi-raw #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jinbao1001
changed the title
fix: searchworker?dumi-raw skip default loader
fix: use define to inject WORKER_CODE instead of resourcequery dumi-raw
Jul 4, 2024
PeachScript
reviewed
Jul 4, 2024
@@ -35,6 +36,16 @@ export default (api: IApi) => { | |||
|
|||
if (cacheDirPath) _setFSCacheDir(path.join(cacheDirPath, 'dumi')); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// inject raw code to use search worker in inline mode |
src/features/compile/index.ts
Outdated
'utf-8', | ||
); | ||
memo.define ??= {}; | ||
memo.define.WORKER_CODE = WORKER_CODE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议用 SEARCH_WORKER_CODE
Jinbao1001
changed the title
fix: use define to inject WORKER_CODE instead of resourcequery dumi-raw
fix: use define to inject SEARCH_WORKER_CODE instead of resourcequery dumi-raw
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是?/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
mako 不支持 resolve '-!xxx', 导致 ?dumi-raw 被 umi default loader 处理
这里将 workerjs 通过 define 注入, 兼容两种 bundler
📝 更新日志 / Changelog