fix: livedemo disabled when config babel-plugin-import #2195
+57
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
requested changes
Sep 9, 2024
PeachScript
reviewed
Sep 9, 2024
PeachScript
reviewed
Sep 9, 2024
|
|
||
| - 不需要 live demo：忽略警告即可 | ||
| - 希望开启 live demo： | ||
| - style: false 直接去掉插件即可 |
There was a problem hiding this comment.
我评论的只是个提纲…语句还是要完善下的，比如 style: false 这个估计没人看得懂，且默认就是 false
PeachScript
reviewed
Sep 9, 2024
| ); | ||
| if (disableFlag) { | ||
| logger.warn( | ||
| 'live demo feature has been automatically disabled since babel-plugin-import be registered, if you want to enable live demo feature, checkout: https://d.umijs.org/guide/faq', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
#2193
💡 需求背景和解决方案 / Background or solution
用户配置按需加载后,
babel-plugin-import会擦除dumi注入livedemo context的相关import * as语句, 导致context内的变量未定义why 禁用 ?
浏览器用户源码编译是不经过
babel-plugin处理的, 目前也没有必要改变这一现状.禁用一不会报错, 二不会影响存量用户.
📝 更新日志 / Changelog