Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: control customized runtime by stage #5055

Closed
wants to merge 1 commit into from

Conversation

CJY0208
Copy link
Member

@CJY0208 CJY0208 commented Jul 18, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • No any feature
Referrence issue

alitajs/umi-plugin-keep-alive#16

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #5055 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5055      +/-   ##
==========================================
+ Coverage   82.84%   82.86%   +0.02%     
==========================================
  Files         153      153              
  Lines        3381     3385       +4     
  Branches      888      889       +1     
==========================================
+ Hits         2801     2805       +4     
  Misses        573      573              
  Partials        7        7              
Impacted Files Coverage Δ
...-built-in/src/plugins/generateFiles/core/plugin.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e52bcd...0ef7d76. Read the comment docs.

@CJY0208
Copy link
Member Author

CJY0208 commented Jul 20, 2020

referrence issue: alitajs/umi-plugin-keep-alive#16

@CJY0208
Copy link
Member Author

CJY0208 commented Jul 20, 2020

存在一定风险,以前自定义运行时必然最末尾

但目前加入了 stage,尽可能给了最小的 stage

但依然可能让某些 runtime 依赖于 stage 的 plugin 的顺序出错

@sorrycc
Copy link
Member

sorrycc commented Jul 20, 2020

不敢合,感觉会有 break change。

@CJY0208
Copy link
Member Author

CJY0208 commented Jul 20, 2020

理解,我再看看我遇到的问题是否有其他解法

目前看到的变化是自定义运行时将会接受 stage 控制,影响 src/.umi/core/plugin.ts 中 自定义运行时的放置顺序

如果是 stage 顺序上的 break change,排查官方 plugin 对 addRuntimePlugin stage 的使用大概可以控制住风险范围

但没办法保证非官方 plugin 是否受影响

其他的 break change 就不太清楚了

@sorrycc
Copy link
Member

sorrycc commented Sep 7, 2020

先 Close 了,有需要再开。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants