Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default 404 for gen conventional routes #5363

Closed
wants to merge 1 commit into from

Conversation

zthxxx
Copy link
Contributor

@zthxxx zthxxx commented Sep 7, 2020

Checklist

  • npm test passes
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

#5349 的另一种解法,不使用插件的方式,直接修复 getConventionalRoutes.ts 中的 getRoutes 函数

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 7, 2020

@sorrycc @ycjcl868 麻烦合一下这个修复,修复 umi3 中一直没实现,但官网文档中有的「约定式 404 路由」

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 8, 2020

@ycjcl868 remind

404 路由的问题解决了,希望赶紧合下代码,这个问题已经持续两个月了

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 8, 2020

@sorrycc @ycjcl868 帮忙看下有啥问题需要改,没有问题的话麻烦合一下代码

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 15, 2020

@ycjcl868 remind, 一周过去了

@zthxxx
Copy link
Contributor Author

zthxxx commented Sep 18, 2020

@sorrycc @ycjcl868 看一下有啥问题需要改嘛 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

约定路由 404.js 没有生效
2 participants