Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links to icons of authentication services #1370

Closed
Ivan-Chupin opened this issue May 30, 2022 · 10 comments · Fixed by #1379
Closed

Broken links to icons of authentication services #1370

Ivan-Chupin opened this issue May 30, 2022 · 10 comments · Fixed by #1379
Assignees
Labels
Milestone

Comments

@Ivan-Chupin
Copy link

When using Remark42 version 1.10.0 in a configuration without a subdomain, links to icons of authentication services are broken. Rollback to version 1.9.0 fixes the bug.
remark42-broken-urls

@umputun
Copy link
Owner

umputun commented May 30, 2022

@paskal @akellbl4 - any clue?

@saosangmo
Copy link
Contributor

saosangmo commented May 30, 2022

I have just installed RM42. I think @Ivan-Chupin has not configured nginx rewrite for path /web/. He may installed with an old document.

I have checked on his own site: https(://)smartdd(.)com. Everything seem works well.

@Ivan-Chupin
Copy link
Author

Nginx is configured correctly. The problem with /web/ when installing Remark42 without a subdomain is known, but unfortunately not resolved. The site works well because I rolled back Remark42 to version 1.9.0

@akellbl4
Copy link
Collaborator

I see possible problem. I'll try to fix it.

@akellbl4
Copy link
Collaborator

akellbl4 commented Jun 5, 2022

@Ivan-Chupin could you please test it on your instance and confirm that this issue was fixed for you?

@akellbl4 akellbl4 reopened this Jun 5, 2022
@Ivan-Chupin
Copy link
Author

Where can I download the corrected executable file?

@umputun
Copy link
Owner

umputun commented Jun 6, 2022

master builds don't produce binary, but docker images, i.e. ghcr.io/umputun/remark42:master

if you really need a binary version let me know what architecture, and I'll build and attach it to this ticket

@Ivan-Chupin
Copy link
Author

linux-amd64

@umputun
Copy link
Owner

umputun commented Jun 6, 2022

remark42.linux-amd64.tar.gz

fyi: you can always build it by running "make release"

@Ivan-Chupin
Copy link
Author

Checked out the new version. The error has been fixed. Thank you.

@paskal paskal added this to the v1.10.1 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants