Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix basepath for oauth icons #1379

Merged
merged 1 commit into from
Jun 5, 2022
Merged

fix basepath for oauth icons #1379

merged 1 commit into from
Jun 5, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jun 5, 2022

Resolves #1370

@akellbl4 akellbl4 requested a review from umputun as a code owner June 5, 2022 22:44
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1379 (6dc9431) into master (20ca089) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   50.34%   50.34%           
=======================================
  Files         139      139           
  Lines        3011     3011           
  Branches      642      690   +48     
=======================================
  Hits         1516     1516           
  Misses       1488     1488           
  Partials        7        7           
Impacted Files Coverage Δ
frontend/app/components/auth/components/oauth.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55f6ff...6dc9431. Read the comment docs.

@umputun umputun merged commit 6936268 into master Jun 5, 2022
@umputun umputun deleted the fix-base-path-icons branch June 5, 2022 22:46
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 562 ms (+68.67% 🔺) 603 ms
public/remark.mjs 65.88 KB (+0.01% 🔺) 1.4 s (+0.01% 🔺) 903 ms (-13.97% 🔽) 2.3 s
public/remark.css 8.17 KB (0%) 164 ms (0%) 0 ms (+100% 🔺) 164 ms
public/last-comments.mjs 31.95 KB (0%) 640 ms (0%) 680 ms (+66.39% 🔺) 1.4 s
public/last-comments.css 3.78 KB (-0.03% 🔽) 76 ms (-0.03% 🔽) 0 ms (+100% 🔺) 76 ms
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 302 ms (-51.11% 🔽) 500 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 258 ms (-0.16% 🔽) 273 ms

@paskal paskal added this to the v1.10.1 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links to icons of authentication services
3 participants