"Disable comments" on the page where there are no comments initially

[ob-tk]

If the admin clicks "Disable comments" on the page where there are no comments, the option does not switch to "Enable comments", the input window is not removed. With each click, in the logs we get "......&ro=1".

However, it is no longer possible to add a comment on this page, we get "Something went wrong. Please try again a bit later".

[umputun]

@Reeywhaar @igoradamenko - I think smth with ui goes a little bit crazy here

[Reeywhaar]

ui goes crazy because if post is marked readonly and there are no comments
/api/v1/find?url=https://remark42.com/demo/&sort=-active&format=tree&site=remark
responds with:

{"details":"can't find comments","error":"no bucket https://remark42.com/demo/ in store"}

While if there are at least one comment and post is read-only the response would be:

{"comments":[▋▋▋▋▋▋▋▋▋],"info":{"url":"https://remark42.com/demo/","count":1,"read_only":true,"first_time":"2019-01-25T16:16:14.7060253-06:00","last_time":"2019-01-25T16:16:14.7060253-06:00"}}

So, in first case ui doesn't know if post is read-only so it can't change button to enable comments because there is no info.read_only in response.

[umputun]

I'd say it is a good reason to go crazy :) Probably I should change response (on api level) in this case and return empty comment list but valid/current info document.

[umputun]

@Reeywhaar I think api should be playing better now for such "no bucket" finds. Can you pls make sure it is all good from UI point of view?

[Reeywhaar]

yep, ui side is broken now, loading spinner and nothing more.

[Reeywhaar]

Right now /api/v1/find returns {comments: null, info: {...}} and null is unexpected value for comments. I'll add check for null but I think it's better to set comments to empty slice by default on the backend too.

Same applies to /api/v1/last

[umputun]

I have fixed find response, however not sure why last affected as I didn't touch it. Probably it always returned null on empty comments. Anyway, made it to return [] as well

[umputun]

@Reeywhaar - if this change working as you expect we could probably drop #264 ?

[Reeywhaar]

Last time the response was treated like error which has been caught, and handled by return of default placeholder data instead.

Edit: you must be talking about last comments endpoint. Well, there must have been an error, it just was that outcome of it is the same (empty widget), so no one noticed.

Let me see if everything works, and if so, I'll drop

[Reeywhaar]

So, yes, everything works good regarding comments.

As for last comments there are errors in console, which I think rather ugly :-) From ui point as I said it's just an empty widget. If you can change response to be [] would be great.

edit:

Anyway, made it to return [] as well

Haven't noticed, it's still null :/

[umputun]

hopefully, this time is [] for real

[Reeywhaar]

yep, now everything great 👍