Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend image proxy to keep local copy of pictures #399

Closed
umputun opened this issue Jul 30, 2019 · 2 comments
Closed

Extend image proxy to keep local copy of pictures #399

umputun opened this issue Jul 30, 2019 · 2 comments
Labels
backend help wanted
Milestone
v1.5

Comments

@umputun
Copy link
Owner

umputun commented Jul 30, 2019

Currently, we have an optional proxy to prevent http/https mixed content. However, often, users post images hosted on some external place and, sometimes, those pictures stored temporarily. To avoid missing pictures, we can extend image proxy functionality or even bridge it to the local image store.

This is going to be optional mode, off by default.
@smaant
Copy link
Collaborator

smaant commented Oct 14, 2019

Added PR #447

umputun pushed a commit that referenced this issue Jan 19, 2020
@smaant @umputun
Preserving external images (issue #399) (#447)
d69495a 
* added passing userID to formatters

* added images preserver

* pinned version of golangci-lint

* implemented caching in proxy

* added tests for caching proxy

* removed previous implementation

* removed passing userID into formatter

This reverts commit 05014a5.

* made linter happy

* removed storing image extension for FS store

* fixed bug with context cancelation preventing reading downloaded image

* fixed bug with trusting return value and ignorring error

* updated README

* added nolint for sha1

* removed unused resized flag

* added backward compatibility for config

* added handling deprecated cli parameter

* corrected func comment

* made linter happy

* made linter happy
@paskal
Copy link
Sponsor Collaborator

paskal commented Dec 19, 2021

IMAGE_PROXY_CACHE_EXTERNAL is the parameter responsible for that, resolving this issue.

@paskal paskal closed this as completed Dec 19, 2021
@paskal paskal added this to the v1.5 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend help wanted
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
3 participants
@umputun @paskal @smaant