Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar fixes after review #1012

Merged
merged 1 commit into from
May 18, 2021
Merged

avatar fixes after review #1012

merged 1 commit into from
May 18, 2021

Conversation

akellbl4
Copy link
Collaborator

Discussed few points with @Mavrin in dm and decided to make changes on it.

@akellbl4 akellbl4 requested a review from Mavrin May 17, 2021 20:34
@akellbl4 akellbl4 requested a review from umputun as a code owner May 17, 2021 20:34
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1012 (3c1615e) into master (93b29e9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   44.01%   44.01%           
=======================================
  Files         127      127           
  Lines        2906     2906           
  Branches      658      657    -1     
=======================================
  Hits         1279     1279           
  Misses       1614     1614           
  Partials       13       13           
Impacted Files Coverage Δ
frontend/app/components/user-info/user-info.tsx 0.00% <ø> (ø)
frontend/app/components/avatar/avatar.tsx 100.00% <100.00%> (ø)
frontend/app/components/comment/comment.tsx 64.85% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b29e9...3c1615e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 17, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.25 KB (0%)
public/remark.mjs 65.23 KB (-0.04% 🔽)
public/remark.css 9.42 KB (0%)
public/last-comments.mjs 30.06 KB (-0.11% 🔽)
public/last-comments.css 5.07 KB (0%)
public/deleteme.mjs 9.76 KB (0%)
public/counter.mjs 601 B (0%)

@umputun umputun merged commit 75196d1 into master May 18, 2021
@umputun umputun deleted the avatar branch May 18, 2021 02:29
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants