Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post messages from iframe #1015

Merged
merged 1 commit into from
Jun 3, 2021
Merged

post messages from iframe #1015

merged 1 commit into from
Jun 3, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 18, 2021

  • fix user info opening
  • remove iframe height checks by interval
  • update height by mutation observer events
  • rename events

@akellbl4 akellbl4 requested a review from Mavrin May 18, 2021 10:05
@akellbl4 akellbl4 requested a review from umputun as a code owner May 18, 2021 10:05
@akellbl4 akellbl4 marked this pull request as draft May 18, 2021 10:27
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1015 (9c4738d) into master (8d8c6ee) will increase coverage by 0.27%.
The diff coverage is 19.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   44.01%   44.28%   +0.27%     
==========================================
  Files         127      126       -1     
  Lines        2906     2897       -9     
  Branches      656      653       -3     
==========================================
+ Hits         1279     1283       +4     
+ Misses       1615     1602      -13     
  Partials       12       12              
Impacted Files Coverage Δ
frontend/app/common/copy.ts 0.00% <0.00%> (ø)
frontend/app/components/dropdown/dropdown.tsx 25.51% <0.00%> (+0.25%) ⬆️
frontend/app/components/root/root.tsx 0.00% <0.00%> (ø)
frontend/app/components/user-info/user-info.tsx 0.00% <0.00%> (ø)
frontend/app/embed.ts 0.00% <0.00%> (ø)
frontend/app/remark.tsx 0.00% <0.00%> (ø)
frontend/app/store/user-info/actions.ts 0.00% <0.00%> (ø)
frontend/app/components/comment/comment.tsx 65.16% <29.41%> (+0.30%) ⬆️
frontend/app/components/auth-panel/auth-panel.tsx 78.16% <33.33%> (ø)
frontend/app/utils/postMessage.ts 42.85% <45.45%> (+42.85%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b392a...9c4738d. Read the comment docs.

@akellbl4 akellbl4 marked this pull request as ready for review May 18, 2021 13:16
@github-actions
Copy link

github-actions bot commented May 19, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.23 KB (-0.87% 🔽)
public/remark.mjs 65.2 KB (-0.12% 🔽)
public/remark.css 9.41 KB (0%)
public/last-comments.mjs 30.06 KB (-0.06% 🔽)
public/last-comments.css 5.07 KB (0%)
public/deleteme.mjs 9.76 KB (0%)
public/counter.mjs 601 B (0%)

@akellbl4 akellbl4 force-pushed the postmessage-to-child branch 5 times, most recently from 59af92b to 0bfa7e2 Compare May 23, 2021 12:06
@akellbl4
Copy link
Collaborator Author

@Mavrin could you please check this PR? :)

Mavrin
Mavrin previously approved these changes May 30, 2021
- fix user info opening
- remove iframe height checks by interval
- update height by mutation observer events
- rename events
@umputun umputun merged commit 3068dfe into master Jun 3, 2021
@umputun umputun deleted the postmessage-to-child branch June 3, 2021 05:56
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants