Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker init script chown command verbose #1020

Merged
merged 1 commit into from
May 24, 2021
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented May 24, 2021

That change ensures that in a situation like one described in #1007, chown doesn't fail silently but carries on with a warning log message, and shows precisely what is wrong in the log. Log after the change:

remark42-dev  | changing ownership of /srv/var to app:app (remark42 user inside the container)
remark42-dev  | chown: /srv/var/docker-init.sh: Read-only file system
remark42-dev  | WARNING: /srv/var ownership change failed, if application will fail that might be the reason
remark42-dev  | execute "/srv/remark42 server"
remark42-dev  | remark42 verbose_chmod-adbd73a-20210524T05:22:15

@paskal paskal requested a review from umputun as a code owner May 24, 2021 10:46
@umputun umputun merged commit 8238772 into master May 24, 2021
@umputun umputun deleted the paskal/verbose_chmod branch May 24, 2021 22:16
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants