Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telegram auth backend support #1022

Merged
merged 1 commit into from
Jul 25, 2021
Merged

add telegram auth backend support #1022

merged 1 commit into from
Jul 25, 2021

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented May 24, 2021

Backend support for telegram auth, #707.

@paskal paskal requested a review from umputun as a code owner May 24, 2021 17:25
@paskal paskal marked this pull request as draft May 24, 2021 17:25
@coveralls
Copy link

coveralls commented May 24, 2021

Pull Request Test Coverage Report for Build 872936918

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.694%

Totals Coverage Status
Change from base Build 872900139: 0.03%
Covered Lines: 5451
Relevant Lines: 6513

💛 - Coveralls

@paskal paskal marked this pull request as ready for review July 25, 2021 18:12
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #1022 (493d53f) into master (68aba33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files         126      126           
  Lines        2906     2906           
  Branches      653      617   -36     
=======================================
  Hits         1284     1284           
  Misses       1610     1610           
  Partials       12       12           
Impacted Files Coverage Δ
frontend/app/common/static-store.ts 100.00% <ø> (ø)
frontend/app/common/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b3776...493d53f. Read the comment docs.

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit ea644a1 into master Jul 25, 2021
@umputun umputun deleted the paskal/telegram_auth branch July 25, 2021 18:16
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants