Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to set telegram API, clarify telegram notify params #1042

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jun 12, 2021

As discussed off-GitHub, remove the ability to set Telegram API (as it's used only in tests) and notify parameters passed as structure in the same way we do with Email notifications now.

@paskal paskal added the backend label Jun 12, 2021
@paskal paskal requested a review from umputun June 12, 2021 22:44
@paskal paskal force-pushed the paskal/telegram_notify_params branch from e2666c2 to babdc27 Compare June 12, 2021 23:13
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minror question

backend/app/notify/telegram.go Show resolved Hide resolved
@umputun umputun merged commit d616798 into master Jun 13, 2021
@umputun umputun deleted the paskal/telegram_notify_params branch June 13, 2021 06:49
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants