Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve README #1057

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Improve README #1057

merged 1 commit into from
Jul 25, 2021

Conversation

rakleed
Copy link
Contributor

@rakleed rakleed commented Jul 19, 2021

  • Update links
  • Update table of contents
  • Improve the design
  • Improve formatting
  • Fix abbreviations and proper names
  • Fix tables
  • Fix indentation in code snippets
  • Fix typos

@rakleed rakleed requested a review from umputun as a code owner July 19, 2021 21:56
@umputun umputun requested a review from akellbl4 July 19, 2021 23:10
paskal
paskal requested changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Just a few comments, otherwise it looks solid.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
frontend/README.md Outdated Show resolved Hide resolved
@rakleed
Improve README
958375b 
* Update links
* Update table of contents
* Improve the design
* Improve formatting
* Fix abbreviations and proper names
* Fix tables
* Fix indentation in code snippets
* Fix typos
@rakleed
Copy link
Contributor Author

rakleed commented Jul 21, 2021

@paskal fixed all the problems.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1057 (958375b) into master (68aba33) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files         126      126           
  Lines        2906     2906           
  Branches      653      617   -36     
=======================================
  Hits         1284     1284           
  Misses       1610     1610           
  Partials       12       12
Impacted Files Coverage Δ
frontend/app/common/static-store.ts 100.00% <ø> (ø)
frontend/app/common/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad54a94...958375b. Read the comment docs.

akellbl4
akellbl4 reviewed Jul 25, 2021
View reviewed changes
site/README.md Show resolved Hide resolved
site/README.md Show resolved Hide resolved
@paskal paskal mentioned this pull request Jul 25, 2021
Merged
@umputun umputun merged commit 50b3776 into umputun:master Jul 25, 2021
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akellbl4 akellbl4 akellbl4 approved these changes

@paskal paskal paskal approved these changes

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@rakleed @umputun @paskal @akellbl4