Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon for paid patreon sub #1318

Merged
merged 2 commits into from
Apr 13, 2022
Merged

add icon for paid patreon sub #1318

merged 2 commits into from
Apr 13, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Apr 10, 2022

Resolves #1125

  • had to fix timer tests due to flaky results

CleanShot 2022-04-10 at 12 07 44@2x

@akellbl4 akellbl4 added this to the 1.9.1 milestone Apr 10, 2022
@akellbl4 akellbl4 requested a review from Mavrin April 10, 2022 20:27
@akellbl4 akellbl4 requested a review from umputun as a code owner April 10, 2022 20:27
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1318 (088397e) into master (5de9544) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 088397e differs from pull request most recent head 174fc1c. Consider uploading reports for the commit 174fc1c to get more accurate results

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
+ Coverage   48.68%   48.73%   +0.05%     
==========================================
  Files         136      136              
  Lines        3071     3074       +3     
  Branches      689      691       +2     
==========================================
+ Hits         1495     1498       +3     
  Misses       1565     1565              
  Partials       11       11              
Impacted Files Coverage Δ
frontend/app/common/types.ts 100.00% <ø> (ø)
...end/app/components/auth/components/oauth.consts.ts 100.00% <ø> (ø)
frontend/app/components/comment/comment.tsx 65.17% <100.00%> (+0.33%) ⬆️
frontend/app/components/countdown/index.tsx 80.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de9544...174fc1c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 10, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
public/embed.mjs 2.02 KB (0%) 41 ms (0%) 369 ms (-16.54% 🔽) 409 ms
public/remark.mjs 65.93 KB (0%) 1.4 s (0%) 958 ms (+40.33% 🔺) 2.3 s
public/remark.css 8.26 KB (0%) 166 ms (0%) 0 ms (+100% 🔺) 166 ms
public/last-comments.mjs 30.96 KB (0%) 620 ms (0%) 310 ms (-18.63% 🔽) 929 ms
public/deleteme.mjs 9.92 KB (0%) 199 ms (0%) 404 ms (+81.11% 🔺) 603 ms
public/counter.mjs 749 B (0%) 15 ms (0%) 399 ms (+17.05% 🔺) 413 ms

@paskal
Copy link
Collaborator

paskal commented Apr 10, 2022

Could you please add a screenshot?

Mavrin
Mavrin previously approved these changes Apr 13, 2022
@umputun umputun merged commit 000d64d into master Apr 13, 2022
@umputun umputun deleted the patreon-paid-subs branch April 13, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of Patreon auth
4 participants