separate persist logic from comment component #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
+ Coverage 57.88% 57.92% +0.03%
==========================================
Files 130 131 +1
Lines 2885 2904 +19
Branches 741 742 +1
==========================================
+ Hits 1670 1682 +12
- Misses 1211 1218 +7
Partials 4 4
Continue to review full report at Codecov.
|
size-limit report 📦
|
Mavrin
reviewed
Jul 11, 2022
| @@ -155,7 +115,7 @@ export class CommentForm extends Component<CommentFormProps, CommentFormState> { | |||
| const { value } = e.target as HTMLInputElement; | |||
| const text = value.substr(0, StaticStore.config.max_comment_size); | |||
|
|
|||
| updateJsonItem(LS_SAVED_COMMENT_VALUE, { [this.props.id]: value }); | |||
| updatePersistedComments(this.props.id, value) | |||
Mavrin
previously approved these changes
Jul 11, 2022
umputun
previously approved these changes
Jul 11, 2022
umputun
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.