Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workspaces #1417

Merged
merged 2 commits into from
Jul 21, 2022
Merged

use workspaces #1417

merged 2 commits into from
Jul 21, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jul 13, 2022

A part of #1409

  • adds pnpm workspaces
  • moves frontend to frontend/apps/remark42 (99% of changes)
  • updates ci jobs

Note: size-limit is crashing because code was moved and it expects it in the same place (when runs check on master)

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1417 (c95e8e9) into master (fddf1e2) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   58.00%   58.12%   +0.12%     
==========================================
  Files         131      131              
  Lines        2900     2909       +9     
  Branches      699      743      +44     
==========================================
+ Hits         1682     1691       +9     
+ Misses       1214     1087     -127     
- Partials        4      131     +127     
Impacted Files Coverage Δ
...tend/app/components/auth/components/oauth.utils.ts
frontend/app/store/thread/utils.ts
frontend/app/components/button/index.ts
frontend/app/components/button/button.tsx
frontend/app/store/comments/reducers.ts
frontend/app/components/tooltip/tooltip.tsx
frontend/app/common/api.getLastComments.ts
frontend/app/components/auth/components/button.tsx
frontend/app/utils/set-dom-props.ts
frontend/app/utils/debounce.ts
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2f2ab...c95e8e9. Read the comment docs.

@akellbl4 akellbl4 force-pushed the workspaces branch 17 times, most recently from 24259ca to e9d24aa Compare July 13, 2022 05:04
@akellbl4 akellbl4 requested a review from Mavrin July 13, 2022 05:08
@akellbl4 akellbl4 marked this pull request as ready for review July 13, 2022 05:09
@akellbl4 akellbl4 requested a review from umputun as a code owner July 13, 2022 05:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2665445563

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.085%

Totals Coverage Status
Change from base Build 2665241525: 0.03%
Covered Lines: 5743
Relevant Lines: 6830

💛 - Coveralls

@akellbl4 akellbl4 force-pushed the workspaces branch 4 times, most recently from bbc054c to 1c17abe Compare July 19, 2022 19:41
Mavrin
Mavrin previously approved these changes Jul 19, 2022
Dockerfile Outdated Show resolved Hide resolved
Dockerfile.artifacts Outdated Show resolved Hide resolved
Copy link
Sponsor Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the fact that this change can't go without a single .md file change. Something should be altered in the frontend dev documentation and maybe a Readme file.

@paskal
Copy link
Sponsor Collaborator

paskal commented Jul 20, 2022

Also please don't merge before #1422, I would like to rebase with newer Dockerfile.

@paskal paskal force-pushed the workspaces branch 3 times, most recently from 7b187e8 to 07584ee Compare July 20, 2022 01:56
@paskal
Copy link
Sponsor Collaborator

paskal commented Jul 20, 2022

paskal
paskal previously approved these changes Jul 20, 2022
@umputun umputun merged commit 6625fac into master Jul 21, 2022
@umputun umputun deleted the workspaces branch July 21, 2022 23:27
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants