Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsubscribe template filename #1445

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fix unsubscribe template filename #1445

merged 1 commit into from
Jul 27, 2022

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jul 27, 2022

Current behavior on click on http://127.0.0.1:8080/email/unsubscribe.html?site=remark&tkn=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcmsiLCJleHAiOjQ4MTI0ODAzNDMsImlzcyI6InJlbWFyazQyIiwibmJmIjoxNjU4ODgwMjgzLCJoYW5kc2hha2UiOnsiaWQiOiJkZXZfdXNlcjo6cGFza2FsLjA3QGdtYWlsLmNvbSJ9fQ.SFwJAS0fv39Bx_L59mVrIbvP0WzuEiUfY_0ROYvgNd0:

remark42-dev  | 2022/07/26 20:17:51.490 [INFO]  {rest/middleware.go:63 rest.Recoverer.func1.1.1} request panic for /email/unsubscribe.html?site=remark&tkn=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZW1hcmsiLCJleHAiOjQ4MTI0ODAzNDMsImlzcyI6InJlbWFyazQyIiwibmJmIjoxNjU4ODgwMjgzLCJoYW5kc2hha2UiOnsiaWQiOiJkZXZfdXNlcjo6cGFza2FsLjA3QGdtYWlsLmNvbSJ9fQ.SFwJAS0fv39Bx_L59mVrIbvP0WzuEiUfY_0ROYvgNd0 from 172.20.0.1:58808, open unsubscribe.html.tmpl: no such file or directory
remark42-dev  | 2022/07/26 20:17:51.492 [INFO]  {rest/middleware.go:65 rest.Recoverer.func1.1.1} goroutine 146 [running]:
remark42-dev  | runtime/debug.Stack()
remark42-dev  |         /usr/local/go/src/runtime/debug/stack.go:24 +0x68

After change: no error, probably something like that as the token is not valid:
image

@paskal paskal added the backend label Jul 27, 2022
@paskal paskal requested a review from akellbl4 July 27, 2022 01:19
@paskal paskal requested a review from umputun as a code owner July 27, 2022 01:19
@paskal paskal merged commit 2a97d93 into master Jul 27, 2022
@paskal paskal deleted the paskal/fix_variable branch July 27, 2022 17:02
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

@akellbl4 akellbl4 Awaiting requested review from akellbl4

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun