Clean up comment HasReplies cache on child comment deletion #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
reviewed
Oct 3, 2022
There was a problem hiding this comment.
looking good. the only thing i would suggest is to add tests on the service level, not just functional test on the rest level, as you did. Those test should be relatively easy to do as you have access to the cache and can check if comments added/removed. Alternatively, you can define a local interface for repliesCache.LoadincCache, mock it and check the interaction with the mock.
paskal
force-pushed
the
paskal/renew_cache_on_delete
branch
from
9a324e8
to
f4f8e39
Compare
Previously, the cache kept the entry and deletion of the parent comment after child deletion was not possible for the rest of cache life (5m) duration. Now it's possible to delete a parent comment after the deletion of the child comment by a user or admin. Resolves #1481
paskal
force-pushed
the
paskal/renew_cache_on_delete
branch
from
f4f8e39
to
ed93ca6
Compare
umputun
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cache kept the entry and deletion of the parent comment after child deletion was not possible for the rest of cache life (5m) duration. Now it's possible to delete a parent comment after the deletion of the child comment by a user or admin.
Resolves #1481