Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move frontend nvmrc to /frontend/ #1566

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Move frontend nvmrc to /frontend/ #1566

merged 1 commit into from
Jan 8, 2023

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jan 8, 2023

Previously we had two .nvmrc files in two locations out of three using node.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 62.35% // Head: 62.35% // No change to project coverage 👍

Coverage data is based on head (b1caf44) compared to base (6ac7503).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1566   +/-   ##
=======================================
  Coverage   62.35%   62.35%           
=======================================
  Files         139      139           
  Lines        3421     3421           
  Branches      803      803           
=======================================
  Hits         2133     2133           
  Misses       1090     1090           
  Partials      198      198           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.76 KB (0%)
public/remark.css 8.12 KB (+0.03% 🔺)
public/last-comments.mjs 35.67 KB (+0.01% 🔺)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@paskal paskal changed the title Add nvmrc to /frontend/ Move frontend nvmrc to /frontend/ Jan 8, 2023
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paskal thanks for the good call and PR

@umputun umputun merged commit 13a3fc3 into master Jan 8, 2023
@umputun umputun deleted the paskal/nvmrc branch January 8, 2023 20:31
@paskal paskal added this to the v1.11.3 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants