Collect /find Info for tree and plain types consistently #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/consistent_info
branch
from
9d9622a
to
07c67ca
Compare
Pull Request Test Coverage Report for Build 8008368310Details
💛 - Coveralls |
paskal
commented
Oct 18, 2023
| @@ -106,7 +84,8 @@ func (t *Tree) proc(comments []store.Comment, node *Node, rd *recurData, parentI | |||
| sort.Slice(node.Replies, func(i, j int) bool { | |||
| return node.Replies[i].Comment.Timestamp.Before(node.Replies[j].Comment.Timestamp) | |||
| }) | |||
| return node, rd.tsModified, rd.tsCreated | |||
| node.tsModified, node.tsCreated = rd.tsModified, rd.tsCreated | |||
There was a problem hiding this comment.
This line is magic, I have no idea why it doesn't mess up tsCreated or tsModified of any of the nodes. Maybe we just don't have good enough test cases to catch it.
paskal
force-pushed
the
paskal/consistent_info
branch
6 times, most recently
from
427e446
to
317bdad
Compare
paskal
force-pushed
the
paskal/consistent_info
branch
2 times, most recently
from
9c146b9
to
7e5fdf0
Compare
paskal
force-pushed
the
paskal/consistent_info
branch
from
7e5fdf0
to
676ecb2
Compare
paskal
force-pushed
the
paskal/consistent_info
branch
from
676ecb2
to
4b0e841
Compare
paskal
force-pushed
the
paskal/consistent_info
branch
from
4b0e841
to
11c5883
Compare
paskal
force-pushed
the
paskal/consistent_info
branch
4 times, most recently
from
4cd4ebe
to
dc232ae
Compare
MakeTree calculated Info locally for historical reasons, and the results were consistent with the dataService.Info call but calculated differently. That change fixes that, ensuring that Info is requested in the same manner.
paskal
force-pushed
the
paskal/consistent_info
branch
from
dc232ae
to
a6f3b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeTree calculated Info locally for historical reasons, and the results were consistent with the dataService.Info call but calculated differently. Requesting plain format comments, on the other hand, had a problem with not returning the read-only status of the page if it doesn't have any comments yet.
That change fixes that, ensuring that Info is requested in the same manner and the read-only status is returned correctly in case the post doesn't have comments but has such a status.