Fix lack of error on file site export, improve lack of ADMIN_PASSWD error message #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7686355908
💛 - Coveralls |
paskal
commented
Jan 28, 2024
| @@ -56,7 +56,6 @@ func (s *rss) postCommentsCtrl(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| w.Header().Set("Content-Type", "application/xml; charset=utf-8") | |||
| w.WriteHeader(http.StatusOK) | |||
|
|
|||
There was a problem hiding this comment.
This is just for consistency. I've checked all WriteHeader(http.StatusOK) for the bug's presence, and that is the only place in the rss.go file with that extra newline, while two others don't.
Previously, status 200 was set for file export, which is used for backup, which resulted in an inability to set an error status code in case of a problem with file generation. After this change, status code 200 would be written automatically by Go before we start writing the response's body.
paskal
force-pushed
the
paskal/fix_backup_error
branch
2 times, most recently
from
714182b
to
6d6c86f
Compare
paskal
changed the title
Previously, the error printed was just the following: error response "401 Unauthorized", Unauthorized" New error: error response "401 Unauthorized", ensure you have set ADMIN_PASSWD and provided it to the command you're running: Unauthorized
paskal
force-pushed
the
paskal/fix_backup_error
branch
from
6d6c86f
to
df06421
Compare
umputun
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, status 200 was set for file export, which is used for backup, which resulted in an inability to set an error status code in case of a problem with file generation.
After this change, status code 200 would be written automatically by Go before we start writing the response's body.
Also, add meaningful error for lack of auth on import, remap and backup.
Previously, the error printed was just the following:
New error: