Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide delete button for non-admin users after edit period expires #1751

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Mar 16, 2024

Resolves #1737. The user couldn't delete their comment once EditDuration passes.

Copy link

github-actions bot commented Mar 16, 2024

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.46 KB (+0.01% 🔺)
public/remark.css 8.26 KB (0%)
public/last-comments.mjs 35.72 KB (+0.01% 🔺)
public/last-comments.css 3.75 KB (0%)
public/deleteme.mjs 12.07 KB (0%)
public/counter.mjs 751 B (0%)

@paskal paskal force-pushed the paskal/hide_delete_after_edit_duretion branch from 49f97c1 to 989c36a Compare March 16, 2024 18:45
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.47%. Comparing base (e1173bb) to head (989c36a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1751   +/-   ##
=======================================
  Coverage   61.47%   61.47%           
=======================================
  Files         132      132           
  Lines        2998     2998           
  Branches      715      715           
=======================================
  Hits         1843     1843           
  Misses       1151     1151           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
@umputun umputun merged commit 5a78169 into master Mar 17, 2024
10 checks passed
@umputun umputun deleted the paskal/hide_delete_after_edit_duretion branch March 17, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Delete" button remains visible in the UI even after the editing period has expired.
3 participants