Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code colors (backend support) #590

Merged
merged 10 commits into from
Feb 9, 2020
Merged

Code colors (backend support) #590

merged 10 commits into from
Feb 9, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Feb 7, 2020

Backend part for #32.

In order to merge it, we need clearance from frontend developers that getting rid of <code> tag won't break anything and they will be able to add CSS to render this code properly.

Also, all review comments should be resolved before the merge.

Example without the language specification

Comment text

```
test text
```

Old render

<pre><code>test text
</code></pre>

New render

<pre class="chroma">test text
</pre>

Example with the language specification

Comment text

```go
func main(aa string) int {return 0}
```

Old render

<pre><code class="language-go">func main(aa string) int {return 0}
</code></pre>

New render

<pre class="chroma"><span class="kd">func</span> <span class="nf">main</span><span class="p">(</span><span class="nx">aa</span> <span class="kt">string</span><span class="p">)</span> <span class="kt">int</span> <span class="p">{</span><span class="k">return</span> <span class="mi">0</span><span class="p">}</span>
</pre>

@github-actions
Copy link

github-actions bot commented Feb 7, 2020

Pull Request Test Coverage Report for Build ddc5f119d-PR-590

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 83.344%

Files with Coverage Reduction New Missed Lines %
backend/app/cmd/server.go 2 80.86%
Totals Coverage Status
Change from base Build b566d7f84: -0.02%
Covered Lines: 5074
Relevant Lines: 6088

💛 - Coveralls

backend/app/store/comment.go Outdated Show resolved Hide resolved
backend/app/store/formatter.go Show resolved Hide resolved
@paskal paskal marked this pull request as ready for review February 7, 2020 23:07
@akellbl4 akellbl4 mentioned this pull request Feb 8, 2020
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with styles #592
LGTM

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit 1e548eb into master Feb 9, 2020
@paskal paskal deleted the code-colors branch February 9, 2020 08:35
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants