Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image.Service and image.Store improvements #628

Merged
merged 6 commits into from
Apr 3, 2020
Merged

image.Service and image.Store improvements #628

merged 6 commits into from
Apr 3, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Mar 27, 2020 •
edited
Loading

Pre-requirement to #625.

  • SizeLimit function removed altogether. MaxSize, MaxHeight, MaxWidth properties of the Store implementations moved to ServiceParams.
  • image.Store.Save signature included filename. The filename is unused in the current implementation and I got rid of it.
  • add clarification commentary to image.Store interface
  • Image validation and resizing is now done in Service and not Store
  • hide image.Store instance is from image.Service consumers
  • I bumped a couple of modules in go.mod to the latest versions.
    Disclaimer: remark/backend v1.5.0 wouldn't work without replace directive in go.mod, because of Outdated style reference to blackfriday module #627. But leaving v1.4.0 in place feels wrong and I bumped it nevertheless.

@paskal paskal requested review from umputun and smaant March 27, 2020 01:11
@paskal paskal changed the title Image interface fixes Image interface improvements Mar 27, 2020
@paskal paskal mentioned this pull request Mar 27, 2020
Merged
@paskal paskal added the backend label Mar 27, 2020
@paskal paskal changed the title Image interface improvements image.Service and image.Store improvements Mar 27, 2020
umputun
umputun approved these changes Apr 3, 2020
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, makes code better.

@umputun umputun merged commit 98b77f0 into umputun:master Apr 3, 2020
@paskal paskal deleted the img_fixes branch April 3, 2020 04:08
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

@smaant smaant Awaiting requested review from smaant

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun