Site-wide email notifications for site owner #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
reviewed
Apr 6, 2020
paskal
force-pushed
the
admin_email_notifications
branch
2 times, most recently
from
df65e20
to
74339ba
Compare
paskal
force-pushed
the
admin_email_notifications
branch
from
74339ba
to
cc97712
Compare
paskal
force-pushed
the
admin_email_notifications
branch
2 times, most recently
from
f0278c6
to
5a65fb1
Compare
paskal
commented
Apr 6, 2020
paskal
commented
Apr 6, 2020
paskal
force-pushed
the
admin_email_notifications
branch
from
5a65fb1
to
946847b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add admin email notifications on new comments. Resolves #633.
Screenshots
Emails on new top-level comment and reply to it, with emails to admin and to parent comment user:
Admin notification on top-level comment, style can be improved by frontenders (@akellbl4 ?):
Notification on reply comment (I've removed "for dev_user" from here as well, screenshot is incorrect only about it):
User notification on reply should be unaltered to the current state: