Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish locale #645

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Spanish locale #645

merged 3 commits into from
Apr 7, 2020

Conversation

lufte
Copy link
Contributor

@lufte lufte commented Apr 7, 2020

Adding the locale file for spanish. I also took the liberty of making a few extra fixes:

  1. Added the translation for the hardcoded text "new page". I used google translate for de, ru and fi; you may want to have someone else look at those.
  2. Made some improvements to one of the localized strings in english that looked weird to me.

If you only want the new locale don't merge the second commit.
Screenshot_2020-04-06_23-46-14

@lufte lufte requested a review from umputun as a code owner April 7, 2020 02:53
@umputun umputun requested review from akellbl4 and Mavrin April 7, 2020 04:29
Mavrin
Mavrin approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@Mavrin Mavrin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
@codiflow could you please check German translation?
@sikmir could you please check Finnish translation?
@umputun Please don't squash commit, because we lost original author.

@umputun umputun merged commit 1bb8fa4 into umputun:master Apr 7, 2020
@codiflow
Copy link
Contributor

codiflow commented Apr 7, 2020

Just see my recent pull request for the German translation: #646

@umputun umputun added this to the v1.6 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

@Mavrin Mavrin Mavrin approved these changes

@akellbl4 akellbl4 Awaiting requested review from akellbl4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@lufte @codiflow @umputun @Mavrin