Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight comment when user went to it by link #660

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

lalentine96
Copy link
Contributor

Resolves #559

Adds .comment_highlighting class after scrolling to comment.

Adds .comment_highlighting class after scrolling to comment.
@paskal paskal requested review from Mavrin and akellbl4 April 11, 2020 17:29
@paskal paskal self-requested a review April 11, 2020 17:36
@paskal
Copy link
Sponsor Collaborator

paskal commented Apr 11, 2020

Thanks for your contribution! LGTM

image

@akellbl4
Copy link
Collaborator

akellbl4 commented Apr 11, 2020

@lalentine96 thanks! LGTM, but I can suggest to add transition: background 0.3s ease-in-out.

It could be better to add paddings to horizontal sides, but now it not available for comments on the first level. I think we can discuss it in a separate issue.

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx

@umputun umputun merged commit 49dd5bd into umputun:master Apr 12, 2020
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight comment when user went to it by link
4 participants