Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artifact filename on arm32 #664

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Conversation

quantonganh
Copy link
Contributor

@umputun umputun merged commit 2e47fde into umputun:master Apr 12, 2020
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
@paskal
Copy link
Sponsor Collaborator

paskal commented Apr 13, 2020

@quantonganh I am pretty sure architecture name is arm and not arm32, I never seen builds with arm32 in name anywhere and couldn't find them now. Why do you think this change is necessary?
//cc @umputun

@paskal
Copy link
Sponsor Collaborator

paskal commented Apr 13, 2020

Here is another link where you can see it goes under name arm and not arm32.

@quantonganh
Copy link
Contributor Author

@paskal You're completely right:

$ go tool dist list | grep arm
linux/arm
linux/arm64

I'm pretty sure I checked the correct architecture name before, but don't know why I just follow the README blindly:

alternatively compile from the sources - make OS=[linux|darwin|windows] ARCH=[amd64,386,arm64,arm32]

It should be fixed to avoid confusion in the future.
Created: #684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants