Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable golangci-lint for tests #697

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Enable golangci-lint for tests #697

merged 2 commits into from
Apr 21, 2020

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Apr 21, 2020

  • enabled golangci-lint for tests
  • fixed discovered problems

@paskal paskal requested a review from umputun April 21, 2020 10:02
@github-actions
Copy link

Pull Request Test Coverage Report for Build 91305b41e-PR-697

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.48%
Totals Coverage Status
Change from base Build b4a6cc547: 0.03%
Covered Lines: 5119
Relevant Lines: 6132
💛 - Coveralls

umputun
umputun approved these changes Apr 21, 2020
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@umputun umputun merged commit cebc40f into master Apr 21, 2020
@paskal paskal deleted the tests_golangci_lint branch April 21, 2020 17:39
@paskal paskal added this to the v1.6 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun