-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations #968
Update translations #968
Conversation
Update translations for - Brazilian Portuguese (`bp.json`) // Not used at the moment, would be nice to support it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts) - German, - Spanish, - French, - Japanese, - Korean, - Russian - Turkish - Chinese (Simplified)
Update translations for - German, - Spanish - French - Japanese - Russian - Turkish - Chinese (Simplified) - Brazilian Portuguese (`bp.json`) // Not used at the moment; would be nice to add support for it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts) - Korean (`ko.json`) // Not used at the moment; would be nice add support for it in [loadLocale.ts](https://github.com/umputun/remark42/blob/master/frontend/app/utils/loadLocale.ts)
Do you possess these languages or used machine translations to update them? Also, would you be so kind as to move new languages into separate MR and generate the code to enable them properly in it? For new languages, the mere presence is better than the lack of the language, so we'll merge them quickly. For existing languages changes, we'll need to check if the new translations are better than the existing ones, which will require more effort from reviewers and will take more time. |
Hi @paskal,
These translations were carried out by professional translators (native speakers) within JetBrains. :)
Sure, I've removed new translations from this PR and created #969 (Add translations for Japanese, Korean, Brazilian Portuguese). Unfortunately I don't have Docker/npm on my machine, perhaps someone from the community will be able to use #969 and add new translations at some point. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
=======================================
Coverage 43.19% 43.19%
=======================================
Files 127 127
Lines 2623 2623
Branches 519 519
=======================================
Hits 1133 1133
Misses 1444 1444
Partials 46 46 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitry-konchalenkov thank you for such contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, thx
Update translations for