Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace deprecated golangci-lint check, fix goleak reports #991

Merged
merged 1 commit into from
May 7, 2021
Merged

replace deprecated golangci-lint check, fix goleak reports #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- name: install golangci-lint and goveralls
run: |
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $GITHUB_WORKSPACE v1.26.0
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $GITHUB_WORKSPACE v1.39.0
go get -u github.com/mattn/goveralls

- name: test and lint backend
Expand Down
4 changes: 2 additions & 2 deletions backend/.golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ linters:
- varcheck
- stylecheck
- gochecknoinits
- scopelint
- exportloopref
- gocritic
- nakedret
- gosimple
Expand All @@ -75,4 +75,4 @@ issues:
exclude-use-default: false

service:
golangci-lint-version: 1.31.x
golangci-lint-version: 1.39.x
8 changes: 1 addition & 7 deletions backend/_example/memory_store/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,12 @@ module github.com/umputun/remark42/memory_store
go 1.14

require (
github.com/go-pkgz/auth v1.15.0 // indirect
github.com/go-pkgz/expirable-cache v0.0.3 // indirect
github.com/go-pkgz/jrpc v0.2.0
github.com/go-pkgz/lcw v0.8.1 // indirect
github.com/go-pkgz/lgr v0.10.4
github.com/go-pkgz/repeater v1.1.3 // indirect
github.com/go-pkgz/rest v1.9.2 // indirect
github.com/go-pkgz/syncs v1.1.1 // indirect
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.7.0
github.com/umputun/go-flags v1.5.1
github.com/umputun/remark42/backend v1.7.1
github.com/umputun/remark42/backend v1.8.1
)

replace github.com/umputun/remark42/backend => ../../
Loading