Change draft relationship #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reflect a new relationship type between drafts & people
user doesn't need to be validated, belongs_to validates presence by default. application templates will have only one draft going forward
when checking in the controller
in a way that reflects the new relationship
that is, no one else is currently editing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always wanted to do this.
So currently, ApplicationTemplates can have multiple drafts, each owned by a different user. That means that Suzie Q can be working on their draft while Joe Schmoe is working on his. Then when they're done, they can each publish! Great, right? NO. Because the resulting application will look like whoever published last. Isn't that going to be true anyways, you say? Not entirely. Here's a scenario: If Suzie adds a question and Joe created his draft before that question was added, Joe's draft will be out of date when it's published and he'll unknowingly remove that question.
The only solution I could see was to make sure there was only ever one draft and only one person could be editing it at once.
It's the second part of that question I'm a little unsure about--would it be bad to have a draft that anyone could edit? Maybe I should talk to Don & company? I can easily remove the functionality where it's locked to one user.
LMK what y'all think.