Switch from webdrivers to just using selenium #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internet tells me that new Selenium can manage your webdriver for you, too. This version doesn't know about the new download location for chromedriver 115 either, but it can download 114 and use that with Chrome 115.
|
Just one warning from Selenium about how it's using webdrivers 114 with Chrome 115. That warning will go away once selenium-webdriver 4.11 is release and we update. |
benmelz
approved these changes
Jul 20, 2023
werebus
added a commit
to umts/jobapps
that referenced
this pull request
Dec 27, 2023
The `webdrivers` gem isn't needed anymore. See umts/screaming-dinosaur#290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internet tells me that new Selenium can manage your webdriver for you, too. This version doesn't know about the new download location for chromedriver 115 either, but it can download 114 and use that with Chrome 115.
This is an alternative to #289, and if Travis builds it successfully, I would say it's preferable.